Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bundle install --target-rbconfig to install gems for Wasm target #490

Merged
merged 21 commits into from
Sep 4, 2024

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@kateinoigakukun kateinoigakukun force-pushed the katei/bundle-install-target-rbconfig branch 2 times, most recently from 72a766b to 99535c5 Compare July 4, 2024 02:07
@kateinoigakukun kateinoigakukun force-pushed the katei/bundle-install-target-rbconfig branch 2 times, most recently from e4ba94f to 0b66668 Compare July 19, 2024 03:41
This helps investigate test failures
In this way, we can avoid the need to specify `BUNDLE_BUILD__JS=--enable-component-model`
when running `bundle install` for the `js` gem. When running `bundle install`, it's usually
dynamic-linking enabled, so it makes sense to enable the component model by default.
The ruby-head-wasm-wasi's Gemfile uses vendor/cache to install js gem
but the cache gem is not yet available at setup-time. And also with
cache gem, the Gemfile is not needed to be installed at setup-time.
So just skip the Gemfile installation here
@kateinoigakukun kateinoigakukun force-pushed the katei/bundle-install-target-rbconfig branch from 049195e to 4d8d2a8 Compare September 4, 2024 08:16
@kateinoigakukun kateinoigakukun merged commit 0b031b2 into main Sep 4, 2024
29 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/bundle-install-target-rbconfig branch September 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant